resolving method resolution order (MRO) to fix docs build #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdb78 mind approve CI run so we can see the actual CI results also here 🐰 |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1497 +/- ##
=======================================
Coverage 90.11% 90.11%
=======================================
Files 30 30
Lines 4724 4724
=======================================
Hits 4257 4257
Misses 467 467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Yes, Black recently introduced big formating change without version change, sadly =( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolved to build docs and so unblocked the long queue with pending PRs
TypeError: Cannot create a consistent method resolution order (MRO) for bases Callback, PyTorchLightningPruningCallbacksee the fixed - 🟢 on forked CI Lightning-Sandbox#1
Checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-filesMake sure to have fun coding!
cc: @jdb78