Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] remove poetry.lock #1651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MNT] remove poetry.lock #1651

wants to merge 1 commit into from

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Sep 4, 2024

Deletes poetry.lock to remove the burden of maintaining it - the developer workflow of installing pytorch-forecasting[dev] is more general and less complex.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Sep 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (6061af6) to head (1f68a8a).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1651   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          32       32           
  Lines        4734     4734           
=======================================
  Hits         4270     4270           
  Misses        464      464           
Flag Coverage Δ
cpu 90.19% <ø> (ø)
pytest 90.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdb78
Copy link
Collaborator

jdb78 commented Sep 7, 2024

Think the only thing to consider is how in the future we want to detect new releases that are breaking the current tests - having a lock file really helps because dependabot creates PRs automatically, updating the lock file and it is immediately clear which updates to dependencies break the tests.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Sep 7, 2024

That's an interesting point! I was wondering where in the workflow the poetry.lock would be useful.

Just to clarify:

  • does poetry.lock monitor each direct and indirect dependency?
  • does it still lock dependencies after the CI is no longer using poetry?

updating the lock file and it is immediately clear which updates to dependencies break the tests.

In my other maintenance workflows, I just run diffs of pip list-s on the first failing CI run, and the last passing CI run. Since testing happens regularly, at least once a week by CRON, only a very small number of versions typically change, and that combined with the error message normally allows to pinpoint the culprit.

For the poetry workflow, I'm just concerned about PR spam...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants