Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ar-tutorial #1655

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Fix/ar-tutorial #1655

merged 2 commits into from
Sep 7, 2024

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented Sep 7, 2024

This PR fixes a device issue for the 'ar' tutorial where tensors were on different devices if a "mps" device is present leading to an error.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (e2bf3fd) to head (dbeb32d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1655   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          32       32           
  Lines        4780     4780           
=======================================
  Hits         4309     4309           
  Misses        471      471           
Flag Coverage Δ
cpu 90.14% <ø> (ø)
pytest 90.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly added the bug Something isn't working label Sep 7, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - any suggestions on how we test this?

I suppose we know that MPS devices are not present on macos-latest by virtue of this?
#1596

So we ought to run the notebooks on macos-latest as well?

@fkiraly fkiraly merged commit 6c66358 into master Sep 7, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants