Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1188: restore proper outcome broken by ISSUE-1136 fix #1189

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fixes #1188: restore proper outcome broken by ISSUE-1136 fix #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/adaptors/tcp/tcp_adaptor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,8 +646,12 @@ static void handle_disconnected(qdr_tcp_connection_t* conn)
"[C%" PRIu64 "][L%" PRIu64 "] handle_disconnected - close out_dlv_stream", conn->conn_id,
conn->outgoing_link_id);

// PN_ACCEPTED: since there is an out_dlv_stream TCP data was transferred
qdr_delivery_remote_state_updated(tcp_adaptor->core, conn->out_dlv_stream, PN_ACCEPTED, true, 0, false);
// PN_ACCEPTED if clean eos occurs, PN_MODIFIED for error like TLS failure so the upstream remote is updated
// correctly:
qdr_delivery_remote_state_updated(tcp_adaptor->core, conn->out_dlv_stream,
conn->read_eos_seen ? PN_ACCEPTED : PN_MODIFIED,
true, // settled
0, false);
qdr_delivery_decref(tcp_adaptor->core, conn->out_dlv_stream, "tcp-adaptor.handle_disconnected - out_dlv_stream");
conn->out_dlv_stream = 0;
}
Expand Down
Loading