Fixes #1694: Additional fix. Capture the first left-most x-forwarded-… #1704
+86
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgiusti
approved these changes
Dec 23, 2024
src/observers/http2/http2_observer.c
Outdated
| // The first X-Forwarded-For header is comma separated list, we will obtain the leftmost (the first) value (2001:db8:85a3:8d3:1319:8a2e:370:7348) in the list | ||
|
|
||
| // const uint8_t *value passed into this function is guaranteed to be NULL-terminated | ||
| char value_copy[valuelen+1]; |
There was a problem hiding this comment.
Is there a limit to valuelen? Can it be large enough to overflow the stack?
I mean, if you only want to capture the first address then you only need a buffer large enough to hold the longest address plus the header. IIRC ipv6 is like 45 chars max, so hardcoding a array size of 128 would be more than enough I would think.
There was a problem hiding this comment.
so hardcoding a array size of 128 would be more than enough I would think.
Agreed. I made the change. Thanks @kgiusti
ganeshmurthy
force-pushed
the
ISSUE-1694-2
branch
from
4a3e70e to
a9a0fd3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // const uint8_t *value passed into this function is guaranteed to be NULL-terminated | ||
| char value_copy[128]; | ||
| strncpy(value_copy, (const char *)value, 128); |
Check warning
Code scanning / GNU C11
'strncpy' specified bound 128 equals destination size Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for header value