Issue #660 - Add additional pre-commit hooks #662
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #662 +/- ##
=======================================
Coverage 25.90% 25.91%
=======================================
Files 128 128
Lines 31195 31195
Branches 4973 4973
=======================================
+ Hits 8081 8083 +2
Misses 22059 22059
+ Partials 1055 1053 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
jiridanek
force-pushed
the
jd_2022_08_05_clang_format_precommit
branch
from
d76d34b
to
0a5f99e
Compare
jiridanek
force-pushed
the
jd_2022_08_05_clang_format_precommit
branch
from
0a5f99e
to
ff460a7
Compare
jiridanek
changed the title
jiridanek
force-pushed
the
jd_2022_08_05_clang_format_precommit
branch
from
ff460a7
to
bae5cf7
Compare
jiridanek
commented
Aug 5, 2022
Comment on lines
499
to
487
| ap->event_sub = qdrc_event_subscribe_CT( | ||
| core, | ||
| QDRC_EVENT_CONN_EDGE_ESTABLISHED | QDRC_EVENT_CONN_EDGE_LOST | QDRC_EVENT_ADDR_BECAME_LOCAL_DEST | ||
| | QDRC_EVENT_ADDR_NO_LONGER_LOCAL_DEST | QDRC_EVENT_ADDR_ONE_LOCAL_DEST | QDRC_EVENT_ADDR_TWO_DEST | ||
| | QDRC_EVENT_ADDR_BECAME_SOURCE | QDRC_EVENT_ADDR_NO_LONGER_SOURCE | QDRC_EVENT_ADDR_TWO_SOURCE | ||
| | QDRC_EVENT_ADDR_ONE_SOURCE | QDRC_EVENT_ADDR_WATCH_ON | QDRC_EVENT_ADDR_WATCH_OFF | ||
| | QDRC_EVENT_LINK_IN_DETACHED | QDRC_EVENT_LINK_OUT_DETACHED, | ||
| on_conn_event, | ||
| on_link_event, | ||
| on_addr_event, | ||
| 0, | ||
| ap); |
There was a problem hiding this comment.
not nice formatting
jiridanek
commented
Aug 5, 2022
| @@ -137,7 +137,14 @@ | |||
| "description": "The standard AMQP management node interface.", | |||
| "fullName": true, | |||
| "extends": "operationalEntity", | |||
| "operations": ["QUERY", "GET-TYPES", "GET-ANNOTATIONS", "GET-OPERATIONS", "GET-ATTRIBUTES", "GET-MGMT-NODES"], | |||
| "operations": [ | |||
There was a problem hiding this comment.
whoops, did not know that clang-format will want to format jsons; means that json has to be added to the filter in git pre-commit, otherwise it's going to create nasty surprise
jiridanek
commented
Aug 5, 2022
| @@ -605,94 +605,93 @@ namespace Color { | |||
| } // namespace Color | |||
|
|
|||
| namespace assertType { | |||
There was a problem hiding this comment.
probably exclude file from pre-commit
jiridanek
force-pushed
the
jd_2022_08_05_clang_format_precommit
branch
from
bae5cf7
to
b8fa10a
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.