Merge pull request #348 from skyflowapi/SK-1196-make-insert-and-delet…

…e-options-parameter-optional-in-js-sdk SK-1196 make insert and delete options parameter optional in js sdk
skyflowapi · Nov 7, 2023 · 65fb4fc · 65fb4fc
2 parents 743d2d1 + 73b141e
commit 65fb4fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/core/external/skyflow-container.ts b/src/core/external/skyflow-container.ts
@@ -145,7 +145,7 @@ class SkyflowContainer {
     });
   }
 
-  insert(records, options:IInsertOptions): Promise<any> {
+  insert(records, options?:IInsertOptions): Promise<any> {
     if (this.#isControllerFrameReady) {
       return new Promise((resolve, reject) => {
         validateInitConfig(this.#client.config);
@@ -370,7 +370,7 @@ class SkyflowContainer {
     });
   }
 
-  delete(records: IDeleteRecordInput, options: IDeleteOptions) {
+  delete(records: IDeleteRecordInput, options?: IDeleteOptions) {
     if (this.#isControllerFrameReady) {
       return new Promise((resolve, reject) => {
         validateInitConfig(this.#client.config);

diff --git a/src/skyflow.ts b/src/skyflow.ts
@@ -202,7 +202,7 @@ class Skyflow {
 
   insert(
     records: IInsertRecordInput,
-    options: IInsertOptions,
+    options?: IInsertOptions,
   ) {
     printLog(parameterizedString(logs.infoLogs.INSERT_TRIGGERED, CLASS_NAME), MessageType.LOG,
       this.#logLevel);
@@ -228,7 +228,7 @@ class Skyflow {
     return this.#skyflowContainer.get(getInput, options);
   }
 
-  delete(records: IDeleteRecordInput, options: IDeleteOptions) {
+  delete(records: IDeleteRecordInput, options?: IDeleteOptions) {
     printLog(parameterizedString(logs.infoLogs.DELETE_TRIGGERED, CLASS_NAME), MessageType.LOG,
       this.#logLevel);
     return this.#skyflowContainer.delete(records, options);