SK-1104 minimize the fetching of card icons.

skyflowapi · Sep 28, 2023 · f160333 · f160333
1 parent 3fa04e6
commit f160333
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/core/internal/iframe-form/index.ts b/src/core/internal/iframe-form/index.ts
@@ -15,6 +15,7 @@ import {
   FRAME_ELEMENT,
   DEFAULT_ERROR_TEXT_ELEMENT_TYPES,
   DEFAULT_REQUIRED_TEXT_ELEMENT_TYPES,
+  CardType,
 } from '../../constants';
 import EventEmitter from '../../../event-emitter';
 import regExFromString from '../../../libs/regex';
@@ -107,6 +108,8 @@ export class IFrameFormElement extends EventEmitter {
 
   containerType: string;
 
+  cardType: string = CardType.DEFAULT;
+
   constructor(name: string, label: string, metaData, context: Context, skyflowID?: string) {
     super();
     const frameValues = name.split(':');

diff --git a/src/core/internal/index.ts b/src/core/internal/index.ts
@@ -274,9 +274,12 @@ export class FrameElement {
       }
       if (this.iFrameFormElement.fieldType === ELEMENTS.CARD_NUMBER.name) {
         const cardType = detectCardType(state.value);
-        if (this.options.enableCardIcon) {
-          if (this.domImg) {
-            this.domImg.src = CARD_ENCODED_ICONS[cardType] || 'none';
+        if (cardType !== this.iFrameFormElement.cardType) {
+          if (this.options.enableCardIcon) {
+            if (this.domImg) {
+              this.domImg.src = CARD_ENCODED_ICONS[cardType] || 'none';
+              this.iFrameFormElement.cardType = cardType;
+            }
           }
         }
         const cardNumberMask = addSeperatorToCardNumberMask(