SK-1372-remove-unnecessary-get-calls-in-insert-batch-operation-js-sdk #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyflow-bharti
force-pushed
the
SK-1372-remove-unnecessary-get-calls-in-insert-batch-operation-js-sdk
branch
from
5a87091
to
7c0ef2e
Compare
skyflow-bharti
force-pushed
the
SK-1372-remove-unnecessary-get-calls-in-insert-batch-operation-js-sdk
branch
from
887d97f
to
09542b6
Compare
skyflow-bharti
force-pushed
the
SK-1372-remove-unnecessary-get-calls-in-insert-batch-operation-js-sdk
branch
from
09542b6
to
b9169bd
Compare
skyflow-bharti
force-pushed
the
SK-1372-remove-unnecessary-get-calls-in-insert-batch-operation-js-sdk
branch
from
eed8b27
to
840e156
Compare
skyflow-bharti
force-pushed
the
SK-1372-remove-unnecessary-get-calls-in-insert-batch-operation-js-sdk
branch
from
840e156
to
a834d89
Compare
skyflow-bharti
requested review from
yaswanth-pula-skyflow,
skyflow-vivek,
skyflow-amith and
skyflow-shashank-prajapati
skyflow-vivek
approved these changes
Jan 22, 2024
| ...(options?.upsert ? { upsert: elseUpsertColumn } : {}), | ||
| }); | ||
| }); | ||
| if (options.continueOnError === undefined) { |
There was a problem hiding this comment.
Please modify this to a proper null check, what if the continueOnError is null ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.