Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace leetcode-cn graphql request query argument which cause 400 #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TangliziGit
Copy link

Since last version released, the graphql request query argument on
leetcode-cn web site have been changed. This commit just replace
question into questionId and convert string fid to int.

Refs: skygragon/leetcode-cli#216

Since last version released, the graphql request query argument on
leetcode-cn web site have been changed. This commit just replace
`question` into `questionId` and convert string fid to int.

Refs: skygragon/leetcode-cli#216
To support for leetcode-cn, the language name should be changed into
lower case.
@TangliziGit
Copy link
Author

To support leetcode-cn, the language name should be changed into lower case.
The leetcode.js plugin was just modified on line 329.

@luyanfei
Copy link

luyanfei commented Sep 7, 2020

Great job! But you should not include leetcode.js commit in the merge request.

@TangliziGit
Copy link
Author

Okay, I will remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants