Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActionReplay cheat function #299

Merged
merged 23 commits into from
Jul 25, 2023
Merged

Add ActionReplay cheat function #299

merged 23 commits into from
Jul 25, 2023

Conversation

OFFTKP
Copy link
Contributor

@OFFTKP OFFTKP commented Jul 19, 2023

The idea is that you add cheats through the UI, convert them to an array of uint32_t, and run each activated cheat using se_run_ar_cheat each frame.

@OFFTKP OFFTKP force-pushed the dev branch 3 times, most recently from 6498bd9 to 45a38ce Compare July 19, 2023 11:56
@OFFTKP OFFTKP force-pushed the dev branch 3 times, most recently from 15d64ed to d4470e6 Compare July 19, 2023 18:55
@OFFTKP
Copy link
Contributor Author

OFFTKP commented Jul 19, 2023

Things missing:

  • Disable input when the edit/add cheat window is focused
  • Better edit/add window layout
  • Actually run the valid cheats from the cheats array
  • Allow for pasting from the clipboard in the input inside the edit/add cheat window

@skylersaleh
Copy link
Owner

It would be cool if we added in reading/writing of a cheat database too

@OFFTKP
Copy link
Contributor Author

OFFTKP commented Jul 20, 2023

What do you think of the code in general?

@skylersaleh
Copy link
Owner

There is a couple of tweaks I want to make. Is it at a good point for me to tag in and make a few changes?

@OFFTKP
Copy link
Contributor Author

OFFTKP commented Jul 21, 2023

Moved the AR code in nds.h (because it's different for every console) and also added the nds9_debug_read/write functions back, lmk if that's fine.

Copy link
Owner

@skylersaleh skylersaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey could you fix up these items?

src/gba.h Show resolved Hide resolved
src/gba.h Show resolved Hide resolved
src/gba.h Outdated Show resolved Hide resolved
src/gba.h Show resolved Hide resolved
src/gba.h Show resolved Hide resolved
@OFFTKP
Copy link
Contributor Author

OFFTKP commented Jul 25, 2023

Hey could you fix up these items?

Done

@skylersaleh skylersaleh merged commit 04c543d into skylersaleh:dev Jul 25, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants