Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't install include/BUILD.bazel #1107

Merged
merged 1 commit into from
Jan 22, 2024
Merged

build: don't install include/BUILD.bazel #1107

merged 1 commit into from
Jan 22, 2024

Conversation

zaucy
Copy link
Contributor

@zaucy zaucy commented Jan 20, 2024

closes #1104

@zaucy zaucy mentioned this pull request Jan 20, 2024
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fedcb92) 100.00% compared to head (9c7136e) 100.00%.
Report is 14 commits behind head on wip.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##               wip     #1107   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          152       152           
  Lines        25341     25341           
=========================================
  Hits         25341     25341

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

skypjack
skypjack approved these changes Jan 22, 2024
View reviewed changes
Copy link
Owner

@skypjack skypjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have done it the other way around probably (as in PATTERN "*.bazel" EXCLUDE) but it's better this way actually. It holds in case we were to add a foo.bar file or similar in the future. 👍

@skypjack skypjack self-assigned this Jan 22, 2024
@skypjack skypjack added the build system requests or issues related to the build system label Jan 22, 2024
@skypjack skypjack changed the base branch from master to wip January 22, 2024 08:42
@skypjack skypjack merged commit 8962212 into skypjack:wip Jan 22, 2024
40 checks passed
skypjack pushed a commit that referenced this pull request Jan 22, 2024
@zaucy @skypjack
build: don't install include/BUILD.bazel (#1107)
60703f6
@zaucy zaucy deleted the dont-install-bazel-in-include branch January 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skypjack skypjack skypjack approved these changes

Assignees

@skypjack skypjack

Labels
build system requests or issues related to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.13.0 installs include/BUILD.bazel
3 participants
@zaucy @codecov-commenter @skypjack