-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create undocumented message bot events #1424
base: main
Are you sure you want to change the base?
Conversation
* message_bot_add * message_bot_remove * these occur on add/remove of incoming webhook
@seratch I would like to add these 2 events to my bot, would you pls review. Also, I suspect you may want unit tests, if so pls give me an overview of what tests you’d like to see, and where they go. |
Thanks for taking the time to send this pull request. Let me mention two points:
|
Thank you @seratch, I reverted unrelated changes. I will mark this PR as ready and then wait until your team gets official word. Tests can be added at that time if you choose to go forward. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
============================================
- Coverage 73.20% 73.15% -0.06%
+ Complexity 4388 4387 -1
============================================
Files 475 475
Lines 14243 14243
Branches 1447 1447
============================================
- Hits 10427 10419 -8
- Misses 2959 2970 +11
+ Partials 857 854 -3 ☔ View full report in Codecov by Sentry. |
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.