Skip to content

Commit

Permalink
Comment
Browse files Browse the repository at this point in the history
Signed-off-by: Henry Robinson <[email protected]>
  • Loading branch information
henryr committed Apr 10, 2024
1 parent ba5be77 commit d859fd0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion go/vt/vtgateproxy/vtgateproxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ func (proxy *VTGateProxy) getConnection(ctx context.Context, target string) (*vt
return existingConn, nil
}

// Otherwise create a new connection.
// Otherwise create a new connection. TODO: confirm this doesn't actually make a TCP connection, and returns quickly,
// otherwise we're going to have to do this while not holding the lock.
conn, err := vtgateconn.DialProtocol(ctx, "grpc", target)
if err != nil {
return nil, err
Expand Down

0 comments on commit d859fd0

Please sign in to comment.