Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions #16

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Add GitHub Actions #16

merged 8 commits into from
Nov 27, 2024

Conversation

JJL772
Copy link
Member

@JJL772 JJL772 commented Jul 17, 2024 •
edited
Loading

Includes the following fixes:

  • Fix quoting in eval expression in Makefile
  • Fix undefined symbols when building with boost python
  • Fix SPACE__ macro. This magic macro broke between make versions, so I replaced it with an (apparently) more portable definition
  • Check for PREEMPT RT instead of just PREEMPT in the SLAC env script
  • Detect rhel7/8/9 in the SLAC env script
  • Added GitHub actions configuration

Replaces travis-ci.

@JJL772 JJL772 requested review from a team and marciodo and removed request for a team July 17, 2024 01:24
@JJL772 JJL772 marked this pull request as draft July 17, 2024 01:25
@JJL772 JJL772 force-pushed the pr-github-actions branch 5 times, most recently from 101c24f to ee61aa0 Compare October 25, 2024 00:00
@JJL772 JJL772 marked this pull request as ready for review October 25, 2024 00:02
@JJL772 JJL772 force-pushed the pr-github-actions branch from ee61aa0 to bbd2840 Compare October 26, 2024 01:25
@JJL772
Copy link
Member Author

JJL772 commented Oct 26, 2024

Before merging, I need to double check that this builds on rhel7

@JJL772
Copy link
Member Author

JJL772 commented Oct 26, 2024

Evidently I broke something :)

@JJL772 JJL772 marked this pull request as draft November 16, 2024 00:50
@JJL772 JJL772 marked this pull request as ready for review November 25, 2024 21:02
@marciodo marciodo merged commit e1c15e2 into master Nov 27, 2024
2 checks passed
@marciodo marciodo deleted the pr-github-actions branch November 27, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marciodo marciodo marciodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JJL772 @marciodo