fix: interpolation bugs

slang-i18n · Sep 16, 2022 · 9ea5baf · 9ea5baf
1 parent 90ece50
commit 9ea5baf
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 3 deletions.
diff --git a/slang/lib/builder/model/node.dart b/slang/lib/builder/model/node.dart
@@ -485,7 +485,10 @@ _ParamWithArg _parseParamWithArg({
   required String input,
   required CaseStyle? paramCase,
 }) {
-  final match = RegexUtils.paramWithArg.firstMatch(input)!;
+  final match = RegexUtils.paramWithArg.firstMatch(input);
+  if (match == null) {
+    throw 'Rich text parameters must follow the syntax: "param(default text)"\nGot instead: "$input"\n';
+  }
   return _ParamWithArg(match.group(1)!.toCase(paramCase), match.group(3));
 }
 

diff --git a/slang/lib/builder/utils/string_interpolation_extensions.dart b/slang/lib/builder/utils/string_interpolation_extensions.dart
@@ -56,9 +56,10 @@ String _replaceBetween({
       buffer.write(curr.substring(0, startIndex));
     }
 
-    int endIndex = curr.indexOf(endCharacter);
+    int endIndex =
+        curr.indexOf(endCharacter, startIndex + startCharacterLength);
     if (endIndex == -1) {
-      buffer.write(curr);
+      buffer.write(curr.substring(startIndex));
       break;
     }
 

diff --git a/slang/test/unit/utils/string_interpolation_extensions_test.dart b/slang/test/unit/utils/string_interpolation_extensions_test.dart
@@ -37,6 +37,21 @@ void main() {
       expect(input.braces(), 'Hello X');
     });
 
+    test('start with closing bracket', () {
+      final input = '} {a}';
+      expect(input.braces(), '} X');
+    });
+
+    test('ends with opening bracket', () {
+      final input = '{a} {';
+      expect(input.braces(), 'X {');
+    });
+
+    test('has double braces instead single braces', () {
+      final input = 'Hello {{a}} {{b}}';
+      expect(input.braces(), 'Hello X} X}');
+    });
+
     test('ignore \\{ only', () {
       final input = 'Hello \\{ World!';
       expect(input.braces(), 'Hello { World!');
@@ -69,6 +84,16 @@ void main() {
       expect(input.doubleBraces(), 'Hello X');
     });
 
+    test('start with closing bracket', () {
+      final input = '}} {{a}}';
+      expect(input.doubleBraces(), '}} X');
+    });
+
+    test('ends with opening bracket', () {
+      final input = '{{a}} {{';
+      expect(input.doubleBraces(), 'X {{');
+    });
+
     test('ignore \\{{ only', () {
       final input = 'Hello \\{{ World!';
       expect(input.doubleBraces(), 'Hello {{ World!');