Skip to content

Commit

Permalink
Fixes: NB#243762 - Ongoing call view: In the status area Muted icon k…
Browse files Browse the repository at this point in the history
…eeps blinking even though call wasn't muted

Bug: NB#243762 - Ongoing call view: In the status area Muted icon keeps blinking even though call wasn't muted
RevBy: TrustMe
  • Loading branch information
Vesa Halttunen committed Apr 20, 2011
1 parent 7169ffb commit 2690deb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions debian/changelog
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
system-ui (0.20.53~1) unstable; urgency=low

* [UNRELEASED]
* Fixes: NB#243762 - Ongoing call view: In the status area Muted icon keeps blinking even though call wasn't muted

-- Vesa Halttunen <[email protected]> Wed, 20 Apr 2011 15:11:56 +0300

Expand Down
2 changes: 1 addition & 1 deletion src/systemui/statusarea/statusindicatoranimationview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ void StatusIndicatorAnimationView::startAnimation()

void StatusIndicatorAnimationView::stopAnimation()
{
if (animationTimeline->state() == QTimeLine::Running && !images.isEmpty()) {
if (animationTimeline->state() == QTimeLine::Running) {
animationTimeline->stop();
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,8 @@ void Ut_StatusIndicatorAnimationView::testChangingAnimate()
QCOMPARE(qTimeLineStartedCalled, false);
QCOMPARE(qTimeLineStoppedCalled, false);

// Stopping should work even if the list is empty
m_subject->getModel()->setValue(QString());
m_subject->getModel()->setAnimate(false);
QCOMPARE(qTimeLineStartedCalled, false);
QCOMPARE(qTimeLineStoppedCalled, true);
Expand Down

0 comments on commit 2690deb

Please sign in to comment.