feat(UI): disable access management ui when no roles are linked to en…

…tity (datahub-project#9610) Co-authored-by: Hendrik Richert <[email protected]>
sleeperdeep · Jun 25, 2024 · b60d647 · b60d647
1 parent e1de993
commit b60d647
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/datahub-web-react/src/app/entity/dataset/DatasetEntity.tsx b/datahub-web-react/src/app/entity/dataset/DatasetEntity.tsx
@@ -198,7 +198,11 @@ export class DatasetEntity implements Entity<Dataset> {
                     component: AccessManagement,
                     display: {
                         visible: (_, _1) => this.appconfig().config.featureFlags.showAccessManagement,
-                        enabled: (_, _2) => true,
+                        enabled: (_, dataset: GetDatasetQuery) => {
+                            const accessAspect = dataset?.dataset?.access;
+                            const rolesList = accessAspect?.roles;
+                            return !!accessAspect && !!rolesList && rolesList.length > 0;
+                        },
                     },
                 },
                 {

diff --git a/datahub-web-react/src/graphql/dataset.graphql b/datahub-web-react/src/graphql/dataset.graphql
@@ -103,6 +103,13 @@ fragment nonSiblingDatasetFields on Dataset {
     assertions(start: 0, count: 1) {
         total
     }
+    access {
+        roles {
+            role {
+                urn
+            }
+        }
+    }
     operations(limit: 1) {
         timestampMillis
         lastUpdatedTimestamp