-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite VSCode extension #1557
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The versioning would be a little bit tricky as VS Code Marketplace does not support |
The problem of placing VSCode extension in another repo is that Could we modify the script and CI to manage VSCode extension's version and publish it separately? |
Sure we could. Than maybe we share with the same minor version, where patch versions are decoupled. In this way we could do 0.59.0 for the first version (so no beta). |
Maybe we even needn't to make any connection between Slidev's main version with VSCode extension's. This is because VSCode extension doesn't use NPM to get dependencies - all dependencies are bundled when publishing. And when main version's minor part updates but extension doesn't have any updates, users may not want to receive an update of extension. |
This PR rewrites the original VSCode extension using
@vue/runtime-core
for state management.Features
src:
option)@slidev/cli
older than this PRTodos
tsup
always bundlesvue.runtime-core.prod.cjs
instead of.bundler.js
Notes
How to debug?
pnpm dev
on monorepo root.F5
in VSCode to launch the extension development host.