Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWIK 1872 Inline spell checker (e.g. browser spell checker) needed when editing slides #947

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

SWIK 1872 Inline spell checker (e.g. browser spell checker) needed when editing slides #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
009d495
Enable native browser spellcheck to CKeditor
kadevgraaf Jul 20, 2018
4f189a3
Added help menu for getting native context menu (to do spellchecking)
kadevgraaf Jul 20, 2018
a79bddb
Test removal of Ckeditor context menu
kadevgraaf Jul 23, 2018
2ce6349
Merge branch 'master' into SWIK-1872---Inline-spell-checker-(e.g.-bro…
kadevgraaf Aug 14, 2018
96c570f
Merge branch 'master' into SWIK-1872---Inline-spell-checker-(e.g.-bro…
kadevgraaf Aug 23, 2018
4a80895
Merge branch 'master' into SWIK-1872---Inline-spell-checker-(e.g.-bro…
abijames Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions assets/ckeditor_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ CKEDITOR.editorConfig = function( config ) {
//Klaas edit -> remove CKeditor red magicline overlay for enter by mouse
config.removePlugins = 'magicline';
//Klaas edit -> remove CKeditor context menu
//config.removePlugins = 'magicline,contextmenu,liststyle,tabletools';
config.removePlugins = 'magicline,contextmenu,liststyle,tabletools';

CKEDITOR.config.magicline_color = '#0000FF';

Expand Down Expand Up @@ -158,7 +158,6 @@ CKEDITOR.editorConfig = function( config ) {
'clipboard,' +
'colorbutton,' +
'colordialog,' +
'contextmenu,' +
'dialogadvtab,' +
'elementspath,' +
'enterkey,' +
Expand Down Expand Up @@ -216,7 +215,7 @@ CKEDITOR.editorConfig = function( config ) {

//config.removeButtons = 'Underline,Subscript,Superscript';


config.disableNativeSpellChecker = false;

//#####Image upload via CKeditor - TODO//
//config.uploadUrl;
Expand Down
5 changes: 3 additions & 2 deletions components/Deck/SlideEditLeftPanel/SlideEditLeftPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,9 @@ class SlideEditLeftPanel extends React.Component {
'&#8226; Bring input box to front or back: press control+shift and then the plus or minus key <br/>' +
'&#8226; Duplicate an input box: control + d <br/>'+
'&#8226; Delete an input box: control + delete <br/>'+
'&#8226; See <a href="https://sdk.ckeditor.com/samples/accessibility.html" target="_blank">https://sdk.ckeditor.com/samples/accessibility.html</a> for more (CKeditor) keyboard shortcuts <br/> <br/>' +
'&#8226; <b>Tip:</b> press the "shift" keyboard button while resizing an image to maintain the width-to-heigth ratio/dimensions of the image <br/>'
'&#8226; See <a href="https://sdk.ckeditor.com/samples/accessibility.html" target="_blank">https://sdk.ckeditor.com/samples/accessibility.html</a> for more (CKeditor) keyboard shortcuts. <br/> <br/>' +
'&#8226; <b>Tip:</b> press the "shift" keyboard button while resizing an image to maintain the width-to-heigth ratio/dimensions of the image. <br/>'+
'&#8226; <b>Tip:</b> Hold the Ctrl or Meta (Mac) key when right-clicking to show your native browser context menu. This is usefull for spellchecking and selecting spell language. <br/>'
}),
//'&#8226; When using Firefox, the selection of text via mouse cursor does not work well. Use keyboard selection or another browser instead. We are working to solve this problem. <br/>' +
type: 'question',
Expand Down