Avoid sending unnecessary build error notifications

Only send error notifications if the last build wasn't already an error.
slluis · Apr 9, 2013 · e500678 · e500678
1 parent 64a5762
commit e500678
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 3 deletions.
diff --git a/Cydin/Cydin.csproj b/Cydin/Cydin.csproj
@@ -212,7 +212,6 @@
     <Folder Include="WebService\" />
     <Folder Include="Views\SiteAdmin\" />
     <Folder Include="Views\Admin\" />
-    <Folder Include="Views\Admin\" />
     <Folder Include="Views\SiteHome\" />
     <Folder Include="Models\" />
   </ItemGroup>

diff --git a/Cydin/Models/SourceTag.cs b/Cydin/Models/SourceTag.cs
@@ -37,6 +37,9 @@ public class SourceTag
 
 		[DataMember]
 		public string Status { get; set; }
+
+		[DataMember]
+		public string LastStatus { get; set; }
 
 		[DataMember]
 		public string Url { get; set; }

diff --git a/Cydin/Models/UserModel.cs b/Cydin/Models/UserModel.cs
@@ -903,8 +903,15 @@ public void BindDownloadInfo (Release rel)
 
 		public void SetSourceTagStatus (SourceTag stag, string status)
 		{
-			bool statusChanged = stag.Status != status;
+			bool statusChanged = false;
 			stag.Status = status;
+
+			if (status != SourceTagStatus.Building && status != SourceTagStatus.Fetching && status != SourceTagStatus.Waiting) {
+				// A final status
+				statusChanged = stag.LastStatus != status;
+				stag.LastStatus = status;
+			}
+
 			stag.BuildDate = DateTime.Now;
 			db.UpdateObject (stag);
 

diff --git a/Cydin/Views/Admin/ProjectsList.aspx b/Cydin/Views/Admin/ProjectsList.aspx
@@ -2,13 +2,14 @@
 <%@ Import Namespace="Cydin.Builder" %>
 <%@ Import Namespace="Cydin.Properties" %>
 <%@ Import Namespace="Cydin.Models" %>
+<%@ Import Namespace="System.Linq" %>
 
 <html xmlns="http://www.w3.org/1999/xhtml">
 <body>
 
 <table>
 <tr><th>Project</th><th>Owner</th><th>Sources</th><th>Releases</th><th>Downloads</th></tr>
-<% foreach (Project p in CurrentUserModel.GetProjects ()) { %>
+<% foreach (Project p in CurrentUserModel.GetProjects ().OrderBy (p => p.Name)) { %>
 <tr>
 <td><%=Html.ActionLink (p.Name, "Index", "Project", new { id = p.Id }, null)%></td>
 <td>

diff --git a/db/create.sql b/db/create.sql
@@ -187,6 +187,7 @@ CREATE TABLE `SourceTag` (
   `DevStatus` int(11) NOT NULL DEFAULT '0',
   `AddinId` varchar(300) DEFAULT NULL,
   `BuildDate` datetime DEFAULT NULL,
+  `LastStatus` varchar(20) DEFAULT NULL,
   PRIMARY KEY (`Id`),
   KEY `new_fk_constraint_st_project` (`ProjectId`),
   KEY `new_fk_constraint_st_source` (`SourceId`),