added Pit documentation #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 37 alerts when merging 3b6c8c3 into 0b2327b - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging dc82e01 into 0b2327b - view on LGTM.com new alerts:
|
builder-247
reviewed
Mar 30, 2020
builder-247
reviewed
Mar 30, 2020
| type: 'string', | ||
| description: 'Genesis map faction either "DEMON" or "ANGEL"', | ||
| }, | ||
| cash_during_prestige_0: { |
There was a problem hiding this comment.
I believe only having these for a single prestige would make more sense.
builder-247
reviewed
Mar 30, 2020
| }, | ||
| }, | ||
| }, | ||
| unlocks_1: { |
There was a problem hiding this comment.
And here perhaps remove others aside 0 and 1.
|
I went ahead and did 0 and 1 for both just for the sake of showing the pattern a little bit better than if it was a single entry for cash_during_prestige_n |
builder-247
approved these changes
Mar 30, 2020
|
This pull request introduces 1 alert when merging 509d338 into 0b2327b - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretty much title, sorry if there's typos. And just now making this pull request I have noticed that my find and replace number to amount affected some other places oops.