Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass device name to the build #40

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Pass device name to the build #40

merged 1 commit into from
Jan 7, 2025

Conversation

dop-amin
Copy link
Collaborator

@dop-amin dop-amin commented Jan 7, 2025

Brings together changes from 1603eac and 16a6fcd while removing the bits specific to the examples.

@dop-amin dop-amin mentioned this pull request Jan 7, 2025
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good. Can you please adjust the commit message to include why you want to do that?

@dop-amin
Copy link
Collaborator Author

dop-amin commented Jan 7, 2025

Change itself looks good. Can you please adjust the commit message to include why you want to do that?

I added a few words on this.

* Reason: When printing benchmark results, it is practical to automatically add the name of the target the benchmark was run on. This eases further processing.
@mkannwischer mkannwischer merged commit 0ceca71 into main Jan 7, 2025
2 checks passed
@mkannwischer mkannwischer deleted the device_name branch January 7, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants