NTTs: remove ldr/str macros that are no longer needed #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mkannwischer
force-pushed
the
simplify-ntt-examples
branch
from
10a3397 to
7476f4c
Compare
|
@mkannwischer This is still relevant, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the aarch64 NTTs by removing the ldr/str macros that are no longer needed because SLOTHY now understands the Neon instructions natively.
@dop-amin, do you happen to have access to a big machine that you could use to re-optimize these and test if they all still work? There is a chance that some
qform_definitions are missing.Side-note: We considered replacing
qform_XXXwith the new syntaxQ<XXX>but that would result in the source assembly not being functional without running it through SLOTHY. So for now we'll stick with the qform.reqs until we have a better idea.