Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: source track v.next draft, address remainder of pre-merge issues #1088

Merged
merged 11 commits into from
Jul 8, 2024

Conversation

zachariahcox
Copy link
Contributor

@zachariahcox zachariahcox commented Jul 2, 2024

closes out the remainder of the pre-merge issues.

changes

  1. adds high-level document status section.
  2. add outstanding TODOs from ☝️ gdoc
  3. add link to label:source-track issues in slsa repo
  4. removes reference to "time" in the definition of "revision."
  5. adds source track links to what's new file.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit e95e3b6
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/668bf0215ac72e0008fba4bb
😎 Deploy Preview https://deploy-preview-1088--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zachariahcox zachariahcox requested a review from TomHennen July 3, 2024 13:30
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zachariahcox zachariahcox marked this pull request as ready for review July 3, 2024 13:50
@TomHennen TomHennen requested a review from a team July 3, 2024 13:53
@TomHennen
Copy link
Contributor

It looks like I technically have permission to merge this, but I don't think that's the right process. Assigning to the 'specification maintainers' for their guidance.

@joshuagl
Copy link
Member

joshuagl commented Jul 3, 2024

It looks like I technically have permission to merge this, but I don't think that's the right process.

Thanks for holding off! Per the CONTRIBUTING guide, content changes should have 3 approvers and allow a minimum of 72h for review: https://github.com/slsa-framework/slsa/blob/main/CONTRIBUTING.md#pull-request-types

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM but please restore the TODO items within the file contents.

Co-authored-by: Joshua Lock <[email protected]>
Signed-off-by: Zachariah Cox <[email protected]>
Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehors lehors merged commit 4b969ad into slsa-framework:main Jul 8, 2024
6 checks passed
@zachariahcox zachariahcox deleted the users/zacox/whatsnew branch October 1, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants