-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content: source track v.next draft, address remainder of pre-merge issues #1088
content: source track v.next draft, address remainder of pre-merge issues #1088
Conversation
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
It looks like I technically have permission to merge this, but I don't think that's the right process. Assigning to the 'specification maintainers' for their guidance. |
Thanks for holding off! Per the CONTRIBUTING guide, content changes should have 3 approvers and allow a minimum of 72h for review: https://github.com/slsa-framework/slsa/blob/main/CONTRIBUTING.md#pull-request-types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM but please restore the TODO items within the file contents.
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes out the remainder of the pre-merge issues.
changes
label:source-track
issues in slsa repo