Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compare instead of signum #347

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Use compare instead of signum #347

merged 1 commit into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. Use compare instead of signum 

    This will give the same result, however there are certain cases where using `signum` for comparisons fails, so it is best to stick with `Integer.compare` even if it is not a specific problem in this case.

While we're in here, we can also use `Byte.toUnsignedInt` for further code clarity in these cases.
    @dmlloyd
    dmlloyd committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4f5a7ef View commit details
    Browse the repository at this point in the history