Use dnsNamesSubsetValidator for IID provisioners #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... when disableCustomSANs is set to 'true'. The DNS names in the certificate request must be a subset of the authorized set of DNS names (from the IID token). The previous functionality required that the DNS names in the certificate request exactly matched the authorized DNS names.
github-actions
bot
added
the
needs triage
hslatman
reviewed
Oct 25, 2024
Comment on lines
202
to
207
| allowed := make(map[string]bool) | ||
| for _, s := range v { | ||
| allowed[s] = true | ||
| } | ||
| for _, s := range req.DNSNames { | ||
| if _, ok := allowed[s]; !ok { |
There was a problem hiding this comment.
This can probably become map[string]struct, and its capacity can be set to len(v), so something like make(map[string]struct, 0, len(v))
maraino
reviewed
Oct 25, 2024
Co-authored-by: Herman Slatman <[email protected]>
Co-authored-by: Herman Slatman <[email protected]>
maraino
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... when disableCustomSANs is set to 'true'.
The DNS names in the certificate request must be a subset of the authorized set of DNS names (from the IID token). The previous functionality required that the DNS names in the certificate request exactly matched the authorized DNS names.