Transport wrappers #2103
Merged
Transport wrappers #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
azazeal
force-pushed
the
panos/transport
branch
from
164b58f to
0545598
Compare
areed
previously approved these changes
Dec 12, 2024
| func (w *Webhook) DoWithContext(ctx context.Context, client *http.Client, reqBody *webhook.RequestBody, data any) (*webhook.ResponseBody, error) { | ||
| // TransportWrapper wraps the set of functions mapping [http.Transport] references to | ||
| // [http.RoundTripper]. | ||
| type TransportWrapper = httptransport.Wrapper |
There was a problem hiding this comment.
The httptransport package is an internal one, to avoid duplication from package to package. Since the function's signature is inside function definitions I thought to compress the signature by declaring a type alias.
authority/provisioner/provisioner.go
Outdated
| @@ -264,6 +264,9 @@ type Config struct { | |||
| // HTTPClient is an HTTP client that trusts the system cert pool and the CA | |||
| // roots. | |||
| HTTPClient *http.Client | |||
| // WrapTransport references the function that should wrap any [http.Transport] initialized | |||
| // down the Config's chain. | |||
| WrapTransport func(*http.Transport) http.RoundTripper | |||
There was a problem hiding this comment.
Why not httptransport.Wrapper?
There was a problem hiding this comment.
Well, it'll be a type alias but it's coming right up.
| @@ -103,6 +104,22 @@ func WithWebhookClient(c *http.Client) Option { | |||
| } | |||
| } | |||
|
|
|||
| // Wrapper wraps the set of functions mapping [http.Transport] references to [http.RoundTripper]. | |||
| type TransportWrapper = httptransport.Wrapper | |||
There was a problem hiding this comment.
See above the above.
dopey
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds references to a transport wrapper that callers may pass in order to inject their own dependecies to references of HTTP clients that the internal packages generate.