Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nebula key + cert verification #1085

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Dec 12, 2023

Nebula added support for using ECDSA with the P-256 curve: slackhq/nebula#769.

This takes #1082, but fixes the breaking change.

I expect they might need some additional parameters in the future to be able to use other ECDSA curves too.

dependabot bot and others added 2 commits December 11, 2023 16:03
Bumps [github.com/slackhq/nebula](https://github.com/slackhq/nebula) from 1.6.1 to 1.8.0.
- [Release notes](https://github.com/slackhq/nebula/releases)
- [Changelog](https://github.com/slackhq/nebula/blob/master/CHANGELOG.md)
- [Commits](slackhq/nebula@v1.6.1...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/slackhq/nebula
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Dec 12, 2023
@hslatman hslatman requested a review from maraino December 12, 2023 16:26
maraino
maraino previously approved these changes Dec 15, 2023
@hslatman hslatman requested a review from a team December 19, 2023 11:26
Copy link
Contributor

@azazeal azazeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hslatman hslatman merged commit 2961f40 into master Dec 19, 2023
14 checks passed
@hslatman hslatman deleted the herman/fix-nebula-verify-with-curve branch December 19, 2023 15:04
@hslatman hslatman added this to the v0.25.2 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants