Add CSR common name to SANs if no other SANs are defined in CSR #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dopey
commented
May 7, 2024
•
dopey
commented
- Fixes [Bug]: CN not added as SAN #1171
github-actions
bot
added
the
needs triage
maraino
requested changes
May 7, 2024
command/certificate/sign.go
Outdated
Comment on lines
449
to
460
| if addCNSAN { | ||
| cnInSANs := false | ||
| for _, v := range sans { | ||
| if v == cr.Subject.CommonName { | ||
| cnInSANs = true | ||
| break | ||
| } | ||
| } | ||
| if !cnInSANs { | ||
| sans = append(sans, cr.Subject.CommonName) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we want to do this only if there are no SANs.
command/certificate/sign.go
Outdated
Comment on lines
182
to
187
| cli.BoolTFlag{ | ||
| Name: "add-cn-san", | ||
| Usage: `Ensure that Common Name from CSR subject is added to Subject Alternative | ||
| Name (SAN) extension of the certificate. This flag is enabled by default. To | ||
| disable default behavior pass the flag as '--add-cn-san=false'.`, | ||
| }, |
There was a problem hiding this comment.
Let's do something like --omit-cn-san as @hslatman suggested.
maraino
requested changes
May 7, 2024
Co-authored-by: Mariano Cano <[email protected]>
maraino
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.