Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 38 message cleanup #83

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

tko-dev
Copy link

@tko-dev tko-dev commented Nov 4, 2024

Issue Ticket
See high level description from Parent MR in smarc2 repo.

Changes

  • Main changes are all regeneration of ROS messages through Unity Robotics interface.
  • Only manual changes were done to Publisher and Subscriber files for Percentage

@tko-dev tko-dev mentioned this pull request Nov 4, 2024
6 tasks
@tko-dev tko-dev marked this pull request as ready for review November 4, 2024 13:06
@KKalem
Copy link

KKalem commented Nov 4, 2024

The "parent" PR on smarc2 is not towards smarc-project but towards your own fork of it :)

@tko-dev
Copy link
Author

tko-dev commented Nov 4, 2024

Fixed parent MR, realized I'm now 10 commits behind upstream master, so will have to rebase. Also will work on updates as discussed via slack

@KKalem KKalem merged commit 514c875 into smarc-project:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants