Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: drop comment about no cloud LLM/NLP being implemented #338

Merged
merged 2 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cumulus_etl/deid/philter.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Philter:
def __init__(self):
# Ensure all the nltk data that our filter_config (below) needs is available.
# In docker deployments, these should already be shipped with our docker image.
nltk.download("averaged_perceptron_tagger", quiet=True)
nltk.download("averaged_perceptron_tagger_eng", quiet=True)

# philter-lite does not seem to have any easy way to reference this default config...?
filter_config = os.path.join(os.path.dirname(__file__), "philter-config.toml")
Expand Down
4 changes: 0 additions & 4 deletions docs/nlp.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ One additional challenge with cloud LLMs is reproducibility,
but recording metadata like the current time and vendor version in the database
along with the results can at least help explain changes over time.

{: .note }
Cloud LLM support has not yet been prioritized, and none are currently supported.
But if a new study did need to talk to a specific vendor, we know how we would integrate it.

### cTAKES

[Apache cTAKES](https://ctakes.apache.org/) is a tried and true method of tagging symptoms in text.
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ dependencies = [
"inscriptis < 3",
"jwcrypto < 2",
"label-studio-sdk < 2",
"nltk >= 3.9, < 4",
"openai < 2",
"oracledb < 3",
"philter-lite < 1",
Expand Down
Loading