Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Image #410

Closed
donni106 opened this issue Nov 30, 2021 · 0 comments · Fixed by #429
Closed

Type Image #410

donni106 opened this issue Nov 30, 2021 · 0 comments · Fixed by #429
Assignees
@digorath
Labels
refactoring Updating existing code
Milestone
2.4.1

Comments

@donni106
Copy link
Member

it is probably a matter of finding a decent name for the destructured source.props. we tried already and failed, that is why we ended up with the solution of not destructuring it. which then causes type inference to malfunction.

changing it to be a typescript file would also be a solution, but i would need to check how many issues that brings with it, due to other things not being typed yet

Originally posted by @digorath in #398 (comment)
@donni106 donni106 added the refactoring Updating existing code label Nov 30, 2021
@donni106 donni106 mentioned this issue Nov 30, 2021
Merged
@digorath digorath self-assigned this Jan 14, 2022
digorath added a commit that referenced this issue Jan 14, 2022
@digorath
fix(image): photo permission bug
b9be567 
- trimmed the uri if present
- destructured source from props again to get rid of type inference issue

SVA-391
#410
@digorath digorath mentioned this issue Jan 14, 2022
Merged
@donni106 donni106 added this to the 2.4.1 milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@digorath digorath

Labels
refactoring Updating existing code
Projects
None yet
Milestone
2.4.1
Development

Successfully merging a pull request may close this issue.

Fix: photo permission bug smart-village-solutions/smart-village-app-app
2 participants
@donni106 @digorath