Feature: app intro #398

digorath · 2021-11-18T14:56:59Z

added new app intro feature
this app intro will be displayed at app start until completed once
it can handle the required permission alerts in a more structured way
the splashscreen and orientation lock handling was moved to the new OnboardingManager component
the handling of system and matomo permissions are now being handled by the new OnboardingManager (and if an app intro is configured through that as well)

SVA-305

How to test:

for testing multiple scenarios it is best to not save that the intro was completed at first by commenting out line 58 of the OnboardingManager
by manipulating the conditions in lines 66 and 80 different situations can be simulated

digorath · 2021-11-18T15:40:30Z

@donni106 i will take care of the todos soon. those will only be minor changes i think, so it is still worthwhile to review already

(done)

digorath · 2021-11-24T10:48:48Z

location services initialization needs to be fixed.
currently it is not properly disabled, if globalsettings do not have it enabled.

src/OnboardingManager.tsx

src/screens/AppIntroScreen.tsx

src/index.js

src/helpers/storageHelper.js

src/jsonValidation/appIntroValidator.ts

src/screens/AppIntroScreen.tsx

src/screens/SettingsScreen.js

src/OnboardingManager.tsx

src/jsonValidation/appIntroValidator.ts

src/screens/HomeScreen.js

src/screens/AppIntroScreen.tsx

- added new component AppIntroScreen - added new dependency react-native-app-intro-slider - added dummy content - added onboarding settings to settings provider - moved status bar to Navigator - added AppIntroScreen to Navigator - now renders the AppIntroScreen instead of the NavigationContainer, as long as onboarding has not been completed SVA-305

- removed custom alert in favour of explanatory intro slide - push in app settings are now initialized through system settings SVA-305

- simplified initialisation logic SVA-305

- removed onboarding from settings context again (except global setting) - added initialization of push etc. at the end of onboarding - moved splash screen handling to onboarding manager - extracted initializers SVA-304

- this makes accessing specific entries easier SVA-304

- added custom matomo provider - this component handles the matomo instance using our custom settings - added matomo functionality to app intro - removed now unused matomo hook and extracted alert - replaced all occurrences of storageHelper.matomoSettings in favor of matomoSettings from matomo helpers SVA-304

- added possibility (and necessity) for server sided configuration of the app intro - added validation of app intro json - removed splashscreen and orientation lock handling from src/index - both are now handled by the onboarding manager - added optional fetchPolicy param to useStaticContent to be able to overrride fetchpolicy SVA-304

SVA-305

- location services where no longer respecting global settings - moved `setInitialGlobalSettings` to the bottom to prevent early rerenders and triggers of useEffects SVA-305

- extracted texts in the process SVA-305

- reintroduced an explanatory comment for screen orientation - added comment for app intro validator - removed unused storage helper entry - disabled dot clicks on app intro screen SVA-305

- removed useTrackAppStart hook - immediately use the created instance to track app start SVA-305

- depending on the outcome of normalize, the resulting dots where sometimes not exactly circular SVA-305

- slightly adjusted button position again - added status bar to app intro screen SVA-305

codeclimate · 2021-12-02T13:43:43Z

Code Climate has analyzed commit 874a8cc and detected 0 issues on this pull request.

View more on Code Climate.

digorath added the enhancement New feature or request label Nov 18, 2021

digorath requested a review from donni106 November 18, 2021 14:57

digorath self-assigned this Nov 18, 2021

donni106 added this to the 2.3.0 milestone Nov 18, 2021

digorath force-pushed the feature/SVA-304-app-intro branch from 1879ce4 to 634ce11 Compare November 24, 2021 09:41