Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New chainIds #21

Merged
merged 7 commits into from
Feb 15, 2024
Merged

New chainIds #21

merged 7 commits into from
Feb 15, 2024

Conversation

stackman27
Copy link
Collaborator

No description provided.

@stackman27 stackman27 requested a review from a team as a code owner February 14, 2024 18:37
@stackman27 stackman27 changed the title generate gochain New chainIds Feb 15, 2024
selectors.yml Outdated Show resolved Hide resolved
selectors.yml Outdated Show resolved Hide resolved
selectors.yml Outdated Show resolved Hide resolved
selectors.yml Outdated Show resolved Hide resolved
selectors.yml Outdated Show resolved Hide resolved
selectors.yml Outdated
@@ -44,6 +62,9 @@ selectors:
84532:
selector: 10344971235874465080
name: "ethereum-testnet-sepolia-base-1"
10200:
selector: 8871595565390010547
name: "gnosis-testnet-chiado"
Copy link
Contributor

@andrevmatos andrevmatos Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, refer to prior art when adding any network which some product may already support!

Suggested change
name: "gnosis-testnet-chiado"
name: "gnosis_chain-testnet-chiado"

@@ -1,11 +1,17 @@
selectors:
# Testnets
31:
selector: 8953668971247136127
name: "bitcoin-testnet-rootstock"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this evm?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they have their own VM that is compatible with EVM

@stackman27 stackman27 merged commit b54d438 into main Feb 15, 2024
1 check passed
@stackman27 stackman27 deleted the sish/test branch February 15, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants