bump chainlink-common; rm unused PluginFactoryConstructor #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
commented
Jan 8, 2025
| @@ -244,5 +216,4 @@ func (p PluginFactory) HealthReport() map[string]error { | |||
| } | |||
|
|
|||
| // Interface compatibility checks. | |||
| var _ core.OCR3ReportingPluginClient = &PluginFactoryConstructor{} | |||
There was a problem hiding this comment.
This type assertion was incompatible with the common bump, but the type is unused anyways.
There was a problem hiding this comment.
Yeah, seems unused. I don't see any references in chainlink repo as well so it should be safe to remove
jmank88
force-pushed
the
BCF-2709-loopp-health
branch
4 times, most recently
from
1ca646e to
f9e9321
Compare
jmank88
force-pushed
the
BCF-2709-loopp-health
branch
from
f9e9321 to
a7ce842
Compare
jmank88
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
jmank88
force-pushed
the
BCF-2709-loopp-health
branch
2 times, most recently
from
9be6038 to
cbd0237
Compare
jmank88
force-pushed
the
BCF-2709-loopp-health
branch
from
d3151ec to
a81f996
Compare
|
mateusz-sekara
approved these changes
Jan 17, 2025
| @@ -244,5 +216,4 @@ func (p PluginFactory) HealthReport() map[string]error { | |||
| } | |||
|
|
|||
| // Interface compatibility checks. | |||
| var _ core.OCR3ReportingPluginClient = &PluginFactoryConstructor{} | |||
There was a problem hiding this comment.
Yeah, seems unused. I don't see any references in chainlink repo as well so it should be safe to remove
silaslenihan
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-2709
Requires:
Supports: