Rearrange Relayer Chain interactions interfaces #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
force-pushed
the
extract-chain-reads
branch
from
24e8a40
to
34d7a88
Compare
ilija42
force-pushed
the
extract-chain-reads
branch
from
34d7a88
to
8286a75
Compare
jmank88
reviewed
Oct 30, 2024
jmank88
reviewed
Oct 30, 2024
jmank88
reviewed
Oct 30, 2024
ilija42
force-pushed
the
extract-chain-reads
branch
from
8286a75
to
51ba2fc
Compare
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
force-pushed
the
extract-chain-reads
branch
from
51ba2fc
to
6a3ac42
Compare
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
changed the title
ilija42
commented
Nov 12, 2024
|
|
||
| // NewContractReader returns a new ContractReader. | ||
| // The format of contractReaderConfig depends on the implementation. | ||
| NewContractReader(ctx context.Context, contractReaderConfig []byte) (types.ContractReader, error) | ||
| NewConfigProvider(context.Context, types.RelayArgs) (types.ConfigProvider, error) |
There was a problem hiding this comment.
Should this contain the chainService? Have to check how Relayer interface is used
jmank88
reviewed
Nov 12, 2024
Comment on lines
+14
to
17
| type ContractWriter = ChainWriter | ||
|
|
||
| // Deprecated: Use ContractWriter instead. | ||
| type ChainWriter interface { |
There was a problem hiding this comment.
Swapping these makes the "correct" type more direct and sets up removal to be a little cleaner later 🤷
Suggested change
| type ContractWriter = ChainWriter | |
| // Deprecated: Use ContractWriter instead. | |
| type ChainWriter interface { | |
| // Deprecated: Use ContractWriter instead. | |
| type ChainWriter = ContractWriter | |
| type ContractWriter interface { |
There was a problem hiding this comment.
ah, didn't realise that was legal
jmank88
reviewed
Nov 12, 2024
| // LatestHead returns the latest head for the underlying chain. | ||
| LatestHead(ctx context.Context) (Head, error) | ||
| // GetChainStatus returns the ChainStatus for this Relayer. | ||
| GetChainStatus(ctx context.Context) (ChainStatus, error) | ||
| // ListNodeStatuses returns the status of RPC nodes. | ||
| ListNodeStatuses(ctx context.Context, pageSize int32, pageToken string) (stats []NodeStatus, nextPageToken string, total int, err error) | ||
| } | ||
|
|
||
| type IChainWriter interface { |
There was a problem hiding this comment.
This is a bummer... 🤔 We could rename it later of course - are you planning to do that? Or leave the deprecated type around for a while?
There was a problem hiding this comment.
Everyone that has context on this is slammed with work, I've been chipping away at the backlog when I have time. Maybe I'll do it, or I'll try to somehow reprioritise the backlog.
ilija42
force-pushed
the
extract-chain-reads
branch
from
6a3ac42
to
4eaa82c
Compare
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports