Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rmn protos #56

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Rmn protos #56

wants to merge 5 commits into from

Conversation

carte7000
Copy link

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: aad6721

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 31, 2025, 1:42 PM

makramkd
makramkd reviewed Jan 31, 2025
View reviewed changes
rmn/v1.6/proto/serialization/keystore.proto
Comment on lines +5 to +7
option go_package = "./;serialization";

message Keystore {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is RMN-only right? Any reason why we'd put it here? Tooling support?

rmn/v1.6/proto/serialization/rageproxy.proto
Comment on lines +5 to +7
option go_package = "./;serialization";

// TODO: convert this entire file to lower snake case https://protobuf.dev/programming-guides/style/#message-field-names
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar q on this, This is RMN-only right? Any reason why we'd put it here? Tooling support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carte7000 @makramkd