Start EncodedLogCollector as soon as filters are loaded

Also: add missing return from lp.loadFilters

pkg/solana/logpoller/filters.go

@@ -241,7 +241,7 @@ func (fl *filters) removeFilterFromIndexes(filter Filter) {
 // Requires LoadFilters to be called at least once.
 func (fl *filters) matchingFilters(addr PublicKey, eventSignature EventSignature) iter.Seq[Filter] {
 	if !fl.loadedFilters.Load() {
-		fl.lggr.Critical("Invariant violation: expected filters to be loaded before call to MatchingFilters")
+		fl.lggr.Critical("Invariant violation: expected filters to be loaded before call to matchingFilters")
 		return nil
 	}
 	return func(yield func(Filter) bool) {

pkg/solana/logpoller/log_poller.go

@@ -186,10 +186,10 @@ func (lp *LogPoller) loadFilters(ctx context.Context) error {
 		case <-retryTicker.C:
 		}
 		err := lp.filters.LoadFilters(ctx)
-		if err != nil {
-			lp.lggr.Errorw("Failed loading filters in init logpoller loop, retrying later", "err", err)
-			continue
+		if err == nil {
+			return nil
 		}
+		lp.lggr.Errorw("Failed loading filters in init logpoller loop, retrying later", "err", err)
 	}
 	// unreachable
 }
@@ -201,6 +201,9 @@ func (lp *LogPoller) run(ctx context.Context) {
 		return
 	}
 
+	// safe to start fetching logs, now that filters are loaded
+	lp.collector.Start(ctx)
+
 	var blocks chan struct {
 		BlockNumber int64
 		Logs        any // to be defined