Encoded log collector happy path test

pkg/solana/logpoller/job_get_block.go

@@ -2,6 +2,7 @@ package logpoller
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/gagliardetto/solana-go"
@@ -75,6 +76,9 @@ func (j *getBlockJob) Run(ctx context.Context) error {
 	events := make([]ProgramEvent, 0, len(block.Transactions))
 	for idx, txWithMeta := range block.Transactions {
 		detail.trxIdx = idx
+		if txWithMeta.Transaction == nil {
+			return fmt.Errorf("failed to parse transaction %d in slot %d: %w", idx, j.slotNumber, errors.New("missing transaction field"))
+		}
 		tx, err := txWithMeta.GetTransaction()
 		if err != nil {
 			return fmt.Errorf("failed to parse transaction %d in slot %d: %w", idx, j.slotNumber, err)

pkg/solana/logpoller/job_get_block_test.go

@@ -34,6 +34,15 @@ func TestGetBlockJob(t *testing.T) {
 		err := job.Run(tests.Context(t))
 		require.ErrorIs(t, err, expectedError)
 	})
+	t.Run("Error if transaction field is not present", func(t *testing.T) {
+		client := mocks.NewRPCClient(t)
+		lggr := logger.Sugared(logger.Test(t))
+		block := rpc.GetBlockResult{Transactions: []rpc.TransactionWithMeta{{Transaction: nil}}}
+		client.EXPECT().GetBlockWithOpts(mock.Anything, slotNumber, mock.Anything).Return(&block, nil).Once()
+		job := newGetBlockJob(client, make(chan Block), lggr, slotNumber)
+		err := job.Run(tests.Context(t))
+		require.ErrorContains(t, err, "failed to parse transaction 0 in slot 42: missing transaction field")
+	})
 	t.Run("Error if fails to get transaction", func(t *testing.T) {
 		client := mocks.NewRPCClient(t)
 		lggr := logger.Sugared(logger.Test(t))
@@ -100,7 +109,7 @@ func TestGetBlockJob(t *testing.T) {
 		txWithMeta1 := rpc.TransactionWithMeta{Transaction: txSigToDataBytes(tx1Signature), Meta: &rpc.TransactionMeta{LogMessages: []string{"log1", "log2"}}}
 		txWithMeta2 := rpc.TransactionWithMeta{Transaction: txSigToDataBytes(tx2Signature), Meta: &rpc.TransactionMeta{LogMessages: []string{"log3"}}}
 		// tx3 must be ignored due to error
-		txWithMeta3 := rpc.TransactionWithMeta{Transaction: txSigToDataBytes(tx2Signature), Meta: &rpc.TransactionMeta{LogMessages: []string{"log4"}, Err: fmt.Errorf("some error")}}
+		txWithMeta3 := rpc.TransactionWithMeta{Transaction: txSigToDataBytes(solana.Signature{10, 11}), Meta: &rpc.TransactionMeta{LogMessages: []string{"log4"}, Err: fmt.Errorf("some error")}}
 		height := uint64(41)
 		block := rpc.GetBlockResult{BlockHeight: &height, Blockhash: solana.Hash{1, 2, 3}, Transactions: []rpc.TransactionWithMeta{txWithMeta1, txWithMeta2, txWithMeta3}}
 		client.EXPECT().GetBlockWithOpts(mock.Anything, slotNumber, mock.Anything).Return(&block, nil).Once()

pkg/solana/logpoller/loader.go

@@ -31,8 +31,6 @@ type ProgramEventProcessor interface {
 }
 
 type RPCClient interface {
-	GetLatestBlockhash(ctx context.Context, commitment rpc.CommitmentType) (out *rpc.GetLatestBlockhashResult, err error)
-	GetBlocks(ctx context.Context, startSlot uint64, endSlot *uint64, commitment rpc.CommitmentType) (out rpc.BlocksResult, err error)
 	GetBlockWithOpts(context.Context, uint64, *rpc.GetBlockOpts) (*rpc.GetBlockResult, error)
 	GetSignaturesForAddressWithOpts(context.Context, solana.PublicKey, *rpc.GetSignaturesForAddressOpts) ([]*rpc.TransactionSignature, error)
 	GetSlot(ctx context.Context, commitment rpc.CommitmentType) (uint64, error)