Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bitmap location parsing for IsWritable and IsSignable on AccountLookups #1017

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Added bitmap location parsing for IsWritable and IsSignable on AccountLookups #1017

merged 2 commits into from
Jan 17, 2025

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Jan 15, 2025 •
edited
Loading

Description

This PR updates AccountLookups to be able to search for AccountMeta values based on a provided Bitmap. This is needed for CCIP messaging ExtraArgs which will contain a bitmap for which accounts are writable.

Requires Dependencies

Resolves Dependencies

@silaslenihan silaslenihan marked this pull request as ready for review January 16, 2025 01:13
@silaslenihan silaslenihan requested review from a team as code owners January 16, 2025 01:13
@silaslenihan silaslenihan mentioned this pull request Jan 16, 2025
Merged
@silaslenihan silaslenihan changed the title Added location parsing for IsWritable and IsSignable on AccountLookups Added bitmap location parsing for IsWritable and IsSignable on AccountLookups Jan 17, 2025
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@aalu1418 aalu1418 enabled auto-merge (squash) January 17, 2025 20:33
@aalu1418 aalu1418 merged commit afa9636 into develop Jan 17, 2025
35 of 36 checks passed
@aalu1418 aalu1418 deleted the cw-accounts-updates branch January 17, 2025 20:36
amit-momin pushed a commit that referenced this pull request Jan 24, 2025
@silaslenihan @amit-momin
Added bitmap location parsing for IsWritable and IsSignable on Accoun…
1bb66cb 
…tLookups (#1017)

* Added location parsing for IsWritable and IsSignable on AccountLookups

* Updated MetaBool to use a bitmap location rather than a bool location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@amit-momin amit-momin amit-momin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silaslenihan @aalu1418 @amit-momin