Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flakiness on parallel solana-test-validator operation #590

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

aalu1418
Copy link
Collaborator

Problem: test flakiness start occurring after upgrading solana image for relay tests

test_helpers_test.go:37: 
        	Error Trace:	/home/runner/work/chainlink-solana/chainlink-solana/pkg/solana/client/test_helpers_test.go:37
        	            				/home/runner/work/chainlink-solana/chainlink-solana/pkg/solana/client/test_helpers_test.go:48
        	Error:      	Received unexpected error:
        	            	rpc call getBalance() on http://127.0.0.1:46261/: Post "http://127.0.0.1:46261/": dial tcp 127.0.0.1:46261: connect: connection refused
        	Test:       	TestSetupLocalSolNode_SimultaneousNetworks
    test_helpers.go:69: 
        	Error Trace:	/home/runner/work/chainlink-solana/chainlink-solana/pkg/solana/client/test_helpers.go:69
        	            				/home/runner/work/chainlink-solana/chainlink-solana/pkg/solana/client/test_helpers_test.go:40
        	            				/home/runner/work/chainlink-solana/chainlink-solana/pkg/solana/client/test_helpers_test.go:48
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	TestSetupLocalSolNode_SimultaneousNetworks

Solution:

  • test validator should point to own directories instead of potentially waiting on the same directory and racing to use/delete it

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit 3fb5534 into develop Feb 13, 2024
24 of 25 checks passed
@aalu1418 aalu1418 deleted the fix/flaky-parallel-solana-test branch February 13, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants