[Non-EVM-1062] Solana Codec events support, Hookup Fuzz tests and cleanup Codec init #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
commented
Dec 19, 2024
| @@ -25,6 +27,27 @@ func TestCodec(t *testing.T) { | |||
| tester := &codecInterfaceTester{} | |||
| RunCodecInterfaceTests(t, tester) | |||
| RunCodecInterfaceTests(t, looptestutils.WrapCodecTesterForLoop(tester)) | |||
|
|
|||
| t.Run("Events are encode-able and decode-able for a single item", func(t *testing.T) { | |||
There was a problem hiding this comment.
Events are encoded/decoded in the same way that accounts are. I only tested this one thing which confirms that the IDL event fields are properly parsed into Codec entries, all the encoding variations are already tested by the codec interface tests that are encoding/decoding accounts
|
jadepark-dev
added a commit
that referenced
this pull request
Dec 19, 2024
* Connect codec interface tests and refactor codec to interface like EVM one * progress * Fully implement Codec interface tests * Run codec tests in loop * Prettify codec and codec tests * Refactor codec nil encoding handling * Revert accidental changes to testIDL.json * Add sonar exclusion for codec test utils * Add sq exclusion for duplications in testutils, add decoder unit tests * Add encoder unit test * Fix lint and rename codec to solanacodec to avoid types name collision * Solana codec entry improvements * Fix Solana codec field casing * minor err messages improvements * Code improvements * Fix encoder unit tests * Fix sonar exclusions * lint * Reorder methods in Solana codec * Fix CR integration tests config * Revert TestNewIDLCodec_WithModifiers deletion * Add comments for codec entry includeDiscriminator option * Add discriminator value check in codec entry Decode * Reuse utils from interface tests for Solana codec interface tests * Fix comment * Fix comment * [Non-EVM-1062] Solana Codec events support, Hookup Fuzz tests and cleanup Codec init (#987) * Add events IDL parsing to codec * temp * Add a basic codec test for event IDL parsing * Cleanup Solana Codec init * Hookup Codec fuzz tests * delete an unnecessary comment * lint --------- Co-authored-by: Jonghyeon Park <[email protected]>
dhaidashenko
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Connect codec interface tests and refactor codec to interface like EVM one * progress * Fully implement Codec interface tests * Run codec tests in loop * Prettify codec and codec tests * Refactor codec nil encoding handling * Revert accidental changes to testIDL.json * Add sonar exclusion for codec test utils * Add sq exclusion for duplications in testutils, add decoder unit tests * Add encoder unit test * Fix lint and rename codec to solanacodec to avoid types name collision * Solana codec entry improvements * Fix Solana codec field casing * minor err messages improvements * Code improvements * Fix encoder unit tests * Fix sonar exclusions * lint * Reorder methods in Solana codec * Fix CR integration tests config * Revert TestNewIDLCodec_WithModifiers deletion * Add comments for codec entry includeDiscriminator option * Add discriminator value check in codec entry Decode * Reuse utils from interface tests for Solana codec interface tests * Fix comment * Fix comment * [Non-EVM-1062] Solana Codec events support, Hookup Fuzz tests and cleanup Codec init (#987) * Add events IDL parsing to codec * temp * Add a basic codec test for event IDL parsing * Cleanup Solana Codec init * Hookup Codec fuzz tests * delete an unnecessary comment * lint --------- Co-authored-by: Jonghyeon Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires Dependencies
Resolves Dependencies