Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCI-3127: report length #418

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

augustbleeds
Copy link
Collaborator

@augustbleeds augustbleeds commented Apr 25, 2024

Adds the report_observations metric, like solana did in smartcontractkit/chainlink-solana#658

Comment on lines +58 to +59
p.feedConfig.Name,
p.feedConfig.Path,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably doesn't matter but why use two different methods of getting Name or Path?
(the cleanup uses the Get<> methods instead)

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@augustbleeds augustbleeds merged commit 50c7a33 into develop Apr 29, 2024
18 of 19 checks passed
@augustbleeds augustbleeds deleted the augustus.BCI-3127.report-length branch April 29, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants