Minor changes

smartcontractkit · Jan 20, 2025 · 402840a · 402840a
1 parent 9c47fdd
commit 402840a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/contracts/package.json b/contracts/package.json
@@ -71,7 +71,7 @@
     "moment": "^2.30.1",
     "prettier": "^3.3.3",
     "prettier-plugin-solidity": "^1.4.1",
-    "solhint": "^5.0.5",
+    "solhint": "^5.0.3",
     "solhint-plugin-chainlink-solidity": "git+https://github.com/smartcontractkit/chainlink-solhint-rules.git#v1.2.1",
     "solhint-plugin-prettier": "^0.1.0",
     "ts-node": "^10.9.2",

diff --git a/contracts/pnpm-lock.yaml b/contracts/pnpm-lock.yaml
diff --git a/contracts/src/v0.8/functions/v1_3_0_zksync/ZKSyncFunctionsRouter.sol b/contracts/src/v0.8/functions/v1_3_0_zksync/ZKSyncFunctionsRouter.sol
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.24;
+pragma solidity ^0.8.19;
 
 import {FunctionsRouter} from "../v1_0_0/FunctionsRouter.sol";
 import {CallWithExactGasZKSync} from "../../shared/call/CallWithExactGasZKSync.sol";
@@ -42,7 +42,7 @@ contract ZKSyncFunctionsRouter is FunctionsRouter {
     );
 
     // 3. Use our library to enforce an exact gas call
-    (bool success, uint256 gasUsed, bytes memory returnData) = CallWithExactGasZKSync._callWithExactGas(
+    (bool success, uint256 gasUsed, bytes memory returnData) = CallWithExactGasZKSync._callWithExactGasSafeReturnData(
       client,
       callbackGasLimit,
       encodedCallback,

diff --git a/contracts/src/v0.8/shared/call/CallWithExactGasZKSync.sol b/contracts/src/v0.8/shared/call/CallWithExactGasZKSync.sol
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.24;
+pragma solidity ^0.8.19;
 
 import {EfficientCall} from "@zksync/contracts/system-contracts/contracts/libraries/EfficientCall.sol";
 import {ISystemContext} from "@zksync/contracts/gas-bound-caller/contracts/ISystemContext.sol";
@@ -33,7 +33,10 @@ library CallWithExactGasZKSync {
   /// @param _maxtotalgas the maximum amount of gas that can be spent by the call.
   /// @param _data The calldata for the call.
   /// @param _maxReturnBytes the maximum amount of bytes that can be returned by the call.
-  function _callWithExactGas(
+  /// @return success whether the call succeeded
+  /// @return retData the return data from the call, capped at maxReturnBytes bytes
+  /// @return gasUsed the gas used by the external call. Does not include the overhead of this function.
+  function _callWithExactGasSafeReturnData(
     address _to,
     uint256 _maxTotalGas,
     bytes calldata _data,