core: cosmos & starknet LOOPP mode only (#16039)

* core: cosmos & starknet LOOPP mode only * Support GOFLAGS in remote plugin installations * Install remote plugins with make target * Use default GOFLAGS from makefile --------- Co-authored-by: chainchad <[email protected]>
smartcontractkit · Feb 7, 2025 · 4fc61bb · 4fc61bb
1 parent 193d825
commit 4fc61bb
Show file tree

Hide file tree

Showing 55 changed files with 652 additions and 2,401 deletions.
diff --git a/GNUmakefile b/GNUmakefile
@@ -68,15 +68,15 @@ install-ocr3-capability: ## Build & install the chainlink-ocr3-capability binary
 .PHONY: install-plugins
 install-plugins: ## Build & install LOOPP binaries for products and chains.
 	cd $(shell go list -m -f "{{.Dir}}" github.com/smartcontractkit/chainlink-feeds) && \
-	go install ./cmd/chainlink-feeds
+	go install $(GOFLAGS) ./cmd/chainlink-feeds
 	cd $(shell go list -m -f "{{.Dir}}" github.com/smartcontractkit/chainlink-data-streams) && \
-	go install ./mercury/cmd/chainlink-mercury
-	cd $(shell go list -m -f "{{.Dir}}" github.com/smartcontractkit/chainlink-cosmos) && \
-	go install ./pkg/cosmos/cmd/chainlink-cosmos
+	go install $(GOFLAGS) ./mercury/cmd/chainlink-mercury
+	cd $(shell go mod download -json github.com/smartcontractkit/chainlink-cosmos@f740e9ae54e79762991bdaf8ad6b50363261c056 | jq -r .Dir) && \
+	go install $(GOFLAGS) ./pkg/cosmos/cmd/chainlink-cosmos
 	cd $(shell go list -m -f "{{.Dir}}" github.com/smartcontractkit/chainlink-solana) && \
-	go install ./pkg/solana/cmd/chainlink-solana
-	cd $(shell go list -m -f "{{.Dir}}" github.com/smartcontractkit/chainlink-starknet/relayer) && \
-	go install ./pkg/chainlink/cmd/chainlink-starknet
+	go install $(GOFLAGS) ./pkg/solana/cmd/chainlink-solana
+	cd $(shell go mod download -json github.com/smartcontractkit/chainlink-starknet/relayer@9a780650af4708e4bd9b75495feff2c5b4054e46 | jq -r .Dir) && \
+	go install $(GOFLAGS) ./pkg/chainlink/cmd/chainlink-starknet
 
 .PHONY: docker ## Build the chainlink docker image
 docker:

diff --git a/core/cmd/chains_commands_integration_test.go b/core/cmd/chains_commands_integration_test.go
@@ -0,0 +1,37 @@
+//go:build integration
+
+package cmd_test
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/smartcontractkit/chainlink/v2/core/cmd"
+	"github.com/smartcontractkit/chainlink/v2/core/internal/cltest"
+	"github.com/smartcontractkit/chainlink/v2/core/internal/testutils/cosmostest"
+	"github.com/smartcontractkit/chainlink/v2/core/services/chainlink"
+)
+
+func TestShell_IndexCosmosChains(t *testing.T) {
+	t.Parallel()
+
+	chainID := cosmostest.RandomChainID()
+	chain := chainlink.RawConfig{
+		"ChainID": chainID,
+		"Nodes": []map[string]any{{
+			"Name":          "primary",
+			"TendermintURL": "http://tender.mint",
+		}},
+	}
+	app := cosmosStartNewApplication(t, chain)
+	client, r := app.NewShellAndRenderer()
+
+	require.NoError(t, cmd.NewChainClient(client, "cosmos").IndexChains(cltest.EmptyCLIContext()))
+	chains := *r.Renders[0].(*cmd.ChainPresenters)
+	require.Len(t, chains, 1)
+	c := chains[0]
+	assert.Equal(t, chainID, c.ID)
+	assertTableRenders(t, r)
+}
diff --git a/core/cmd/chains_commands_test.go b/core/cmd/chains_commands_test.go
@@ -7,38 +7,17 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
-	coscfg "github.com/smartcontractkit/chainlink-cosmos/pkg/cosmos/config"
 	solcfg "github.com/smartcontractkit/chainlink-solana/pkg/solana/config"
 
 	client2 "github.com/smartcontractkit/chainlink-integrations/evm/client"
 	"github.com/smartcontractkit/chainlink-integrations/evm/utils/big"
 	"github.com/smartcontractkit/chainlink/v2/core/cmd"
 	"github.com/smartcontractkit/chainlink/v2/core/internal/cltest"
 	"github.com/smartcontractkit/chainlink/v2/core/internal/testutils"
-	"github.com/smartcontractkit/chainlink/v2/core/internal/testutils/cosmostest"
 	"github.com/smartcontractkit/chainlink/v2/core/internal/testutils/solanatest"
 	"github.com/smartcontractkit/chainlink/v2/core/services/chainlink"
 )
 
-func TestShell_IndexCosmosChains(t *testing.T) {
-	t.Parallel()
-
-	chainID := cosmostest.RandomChainID()
-	chain := coscfg.TOMLConfig{
-		ChainID: ptr(chainID),
-		Enabled: ptr(true),
-	}
-	app := cosmosStartNewApplication(t, &chain)
-	client, r := app.NewShellAndRenderer()
-
-	require.NoError(t, cmd.NewChainClient(client, "cosmos").IndexChains(cltest.EmptyCLIContext()))
-	chains := *r.Renders[0].(*cmd.ChainPresenters)
-	require.Len(t, chains, 1)
-	c := chains[0]
-	assert.Equal(t, chainID, c.ID)
-	assertTableRenders(t, r)
-}
-
 func newRandChainID() *big.Big {
 	return big.New(testutils.NewRandomEVMChainID())
 }

diff --git a/core/cmd/cosmos_transaction_commands.go b/core/cmd/cosmos_transaction_commands.go
@@ -5,8 +5,8 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"math/big"
 
-	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/urfave/cli"
 	"go.uber.org/multierr"
 
@@ -67,31 +67,25 @@ func (s *Shell) CosmosSendNativeToken(c *cli.Context) (err error) {
 		return s.errorOut(errors.New("four arguments expected: token, amount, fromAddress and toAddress"))
 	}
 
-	err = sdk.ValidateDenom(c.Args().Get(0))
-	if err != nil {
-		return s.errorOut(fmt.Errorf("invalid native token: %w", err))
+	token := c.Args().Get(0)
+	if token == "" {
+		return s.errorOut(errors.New("missing token"))
 	}
 
-	amount, err := sdk.NewDecFromStr(c.Args().Get(1))
-	if err != nil {
-		return s.errorOut(multierr.Combine(
-			fmt.Errorf("invalid coin: %w", err)))
+	unparsedAmount := c.Args().Get(1)
+	amount, ok := new(big.Int).SetString(unparsedAmount, 10)
+	if !ok {
+		return s.errorOut(fmt.Errorf("invalid int: %s", unparsedAmount))
 	}
 
 	unparsedFromAddress := c.Args().Get(2)
-	fromAddress, err := sdk.AccAddressFromBech32(unparsedFromAddress)
-	if err != nil {
-		return s.errorOut(multierr.Combine(
-			fmt.Errorf("while parsing withdrawal source address %v",
-				unparsedFromAddress), err))
+	if unparsedFromAddress == "" {
+		return s.errorOut(errors.New("missing from address"))
 	}
 
 	unparsedDestinationAddress := c.Args().Get(3)
-	destinationAddress, err := sdk.AccAddressFromBech32(unparsedDestinationAddress)
-	if err != nil {
-		return s.errorOut(multierr.Combine(
-			fmt.Errorf("while parsing withdrawal destination address %v",
-				unparsedDestinationAddress), err))
+	if unparsedDestinationAddress == "" {
+		return s.errorOut(errors.New("missing destination address"))
 	}
 
 	chainID := c.String("id")
@@ -100,11 +94,11 @@ func (s *Shell) CosmosSendNativeToken(c *cli.Context) (err error) {
 	}
 
 	request := cosmos.SendRequest{
-		DestinationAddress: destinationAddress,
-		FromAddress:        fromAddress,
+		DestinationAddress: unparsedDestinationAddress,
+		FromAddress:        unparsedFromAddress,
 		Amount:             amount,
 		CosmosChainID:      chainID,
-		Token:              c.Args().Get(0),
+		Token:              token,
 		AllowHigherAmounts: c.IsSet("force"),
 	}
 

diff --git a/core/cmd/cosmos_transaction_commands_test.go b/core/cmd/cosmos_transaction_commands_test.go