Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Impl of SBRV #13813

Merged
merged 148 commits into from
Jul 31, 2024
Merged

Initial Impl of SBRV #13813

merged 148 commits into from
Jul 31, 2024

Conversation

Fletch153
Copy link
Collaborator

No description provided.

@Fletch153 Fletch153 requested a review from a team July 10, 2024 17:48
@samsondav samsondav requested a review from a team as a code owner July 11, 2024 14:34
@app-token-issuer-infra-releng app-token-issuer-infra-releng bot requested review from a team as code owners July 11, 2024 15:34
This was referenced Jul 12, 2024
Merged
Merged
@Fletch153 Fletch153 requested a review from samsondav July 29, 2024 22:19
dav009 and others added 6 commits July 30, 2024 10:34
@dav009
llo-feeds: testing multiple fee managers and verifiers
f4c97a3
@dav009
llo: fixing tests
d98f9b4
@dav009 @msuchacz-cll
Update contracts/src/v0.8/llo-feeds/v0.4.0/test/verifier/DestinationV…
4c1c051 
…erifierTestRewardsMultiVefifierFeeManager.t.sol

Co-authored-by: msuchacz-cll <[email protected]>
@dav009
llo: v0.4.0 interfaces test
5ee02c1
@Fletch153
Merge pull request #13958 from smartcontractkit/feature/MERC-5829-int…
fae21fc 
…erfaces-test

MERC-5889: SBRV tests for v0.4.0 interfaces
@Fletch153
Merge pull request #13936 from smartcontractkit/feature/MERC-5829-tes…
6b63b89 
…ts-for-many-to-one-verifier-rewardmanager

MERC-5889: SBRV tests for many to one verifier FeeManager and RewardManager
ad0ll
ad0ll previously approved these changes Jul 31, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited
Loading

LCOV of commit 0971985 during Solidity Foundry #40298

Summary coverage rate:
  lines......: 98.7% (1838 of 1862 lines)
  functions..: 96.6% (344 of 356 functions)
  branches...: 90.7% (782 of 862 branches)

Files changed coverage rate: n/a

@Fletch153 Fletch153 enabled auto-merge July 31, 2024 10:49
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@samsondav samsondav requested a review from ad0ll July 31, 2024 10:55
@Fletch153 Fletch153 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into develop with commit c4ffbfb Jul 31, 2024
118 of 119 checks passed
@Fletch153 Fletch153 deleted the feature/MERC-5829/SBRV branch July 31, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad0ll ad0ll ad0ll approved these changes

@samsondav samsondav samsondav approved these changes

@RensR RensR Awaiting requested review from RensR

@archseer archseer Awaiting requested review from archseer

@bolekk bolekk Awaiting requested review from bolekk

@patrick-dowell patrick-dowell Awaiting requested review from patrick-dowell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fletch153 @samsondav @ad0ll @dav009