Fix multichain keybundle #13933
Closed
Fix multichain keybundle #13933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
force-pushed
the
fix-multichain-keybundle
branch
from
fcda12d to
d7ac4c7
Compare
cedric-cordenier
force-pushed
the
fix-multichain-keybundle
branch
from
d7ac4c7 to
8545bb9
Compare
samsondav
previously approved these changes
Aug 1, 2024
cedric-cordenier
force-pushed
the
fix-multichain-keybundle
branch
from
a7b1c62 to
f2ca346
Compare
app-token-issuer-infra-releng
bot
requested review from
a team,
RensR,
matYang,
RayXpub and
elatoskinas
as code owners
archseer
removed request for
a team,
matYang,
RensR,
elatoskinas,
RayXpub and
chris-de-leon-cll
archseer
reviewed
Sep 4, 2024
| "0x61925685d2B80b121537341d063c4E57B2F9323c", | ||
| "0xFd97eFD53FC20acc098Fcd746C04d8d7540D97E0", | ||
| "0xA0b67Dc5345a71D02B396147AE2cb75dDA63CbE9" | ||
| "011400a2402db8e549f094ea31e1c0edd77623f4ca5b12", |
There was a problem hiding this comment.
01 = type evm | 14 00 = length 20 | ...
archseer
reviewed
Sep 4, 2024
|
|
||
| k, err := chaintype.NewChainType(typ) | ||
| if err != nil { | ||
| // skipping unknown key type |
There was a problem hiding this comment.
I'm deliberately skipping unknown keys, that way if the contract is configured with chain types not yet known to the node it'll keep working
archseer
force-pushed
the
fix-multichain-keybundle
branch
3 times, most recently
from
4b67da4 to
528f854
Compare
Overriding _report doesn't actually provide a clear error since transmissions will fail much earlier in the transmit function. Replacing this function should also make this contract cheaper to deploy since we're not deploying unused code.
archseer
force-pushed
the
fix-multichain-keybundle
branch
from
4c6219a to
ad7a91b
Compare
|
Reopened here #14369 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Dependencies
Resolves Dependencies