(SHIP-2626) added custom error handling for Treasure #13981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaechiokolobi
changed the title
dimriou
reviewed
Aug 1, 2024
amit-momin
reviewed
Aug 6, 2024
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
…it/chainlink into ship-2626-treasure-errors
amit-momin
requested changes
Aug 8, 2024
…it/chainlink into ship-2626-treasure-errors
| @@ -405,6 +405,7 @@ func Test_Eth_Errors_Fatal(t *testing.T) { | |||
| {"failed to forward tx to sequencer, please try again. Error message: 'invalid sender'", true, "Mantle"}, | |||
|
|
|||
| {"client error fatal", true, "tomlConfig"}, | |||
| {"invalid chain id for signer", true, "Treasure"}, | |||
There was a problem hiding this comment.
seems like you have four separate error messages categorized for TreasureFatal, maybe add three others here in the test as well ?
There was a problem hiding this comment.
Can I just remove those as they were copied from Arbitrum and not relevant actually
There was a problem hiding this comment.
I see, then you should keep it, as this case is unique for Treasure
There was a problem hiding this comment.
I've left the invalid chain id for signer, and removed the others
amit-momin
approved these changes
Aug 16, 2024
huangzhen1997
approved these changes
Aug 16, 2024
jmank88
approved these changes
Aug 16, 2024
prashantkumar1982
approved these changes
Aug 16, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Dependencies
Resolves Dependencies