Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing step id to action #14088

Merged
merged 3 commits into from
Aug 9, 2024
Merged

add missing step id to action #14088

merged 3 commits into from
Aug 9, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Aug 9, 2024

  • add missing step id
  • do not fail artifact generation, when Slither fails, but display warning in summary and logs

@Tofel Tofel force-pushed the fix_foundry_version_extraction branch from e0f1ec6 to d747856 Compare August 9, 2024 12:50
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Tofel Tofel requested a review from chainchad August 9, 2024 13:25
@Tofel Tofel marked this pull request as ready for review August 9, 2024 13:25
@Tofel Tofel requested review from a team and RensR as code owners August 9, 2024 13:25
@Tofel Tofel added this pull request to the merge queue Aug 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 9, 2024
@Tofel Tofel added this pull request to the merge queue Aug 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 9, 2024
@Tofel Tofel added this pull request to the merge queue Aug 9, 2024
Merged via the queue into develop with commit 349778b Aug 9, 2024
120 checks passed
@Tofel Tofel deleted the fix_foundry_version_extraction branch August 9, 2024 14:30
AnieeG pushed a commit that referenced this pull request Aug 30, 2024
* add missing step id

* do not fail if Slither fails

* try with not failing generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants